1. 27 Apr, 2021 4 commits
    • Robert Knight's avatar
      Set focused state correctly for new highlights · a5c587c8
      Robert Knight authored
      If the user hovered an annotation card before anchoring in the document
      completed, or if an annotation was re-anchored in a PDF after the card
      was hovered, then the highlight in the document was incorrectly shown in
      an un-focused rather than focused state.
      
      Fix the issue by keeping track of the current set of focused annotations
      in the Guest and setting the focus state correctly for new highlights
      added by `anchor`.
      
      Part of https://github.com/hypothesis/client/issues/3269
      a5c587c8
    • Robert Knight's avatar
      Revise comments and a variable name · 1bbd153c
      Robert Knight authored
       - Revise the documentation for `createPlaceholder` to better explain
         what a placeholder is and the 1:N relationship between placeholders
         and highlights for a given page. Also clarify what the "approximate
         location" means
      
       - Rename a variable `isPlaceholder` => `inPlaceholder` as this is more
         accurate
      1bbd153c
    • Robert Knight's avatar
      Fix a bug in `isInPlaceholder` · 8bcc9973
      Robert Knight authored
      Fix incorrect result if the passed node has no parent.
      8bcc9973
    • Robert Knight's avatar
      Encapsulate logic for anchoring placeholders in a new module · 3b054855
      Robert Knight authored
      Several different parts of the code need to know about placeholder
      elements used to anchor annotations that refer to not-yet-rendered pages
      of a document in a PDF. Centralize the logic for creating placeholders
      and testing whether a node is inside a placeholder in one module.
      
      A trivial changes it that the "Loading annotations" text now ends with
      an ASCII "..." instead of unicode ellipsis "…". This is easier to type
      since the text is not intended to be seen by the user.
      3b054855
  2. 26 Apr, 2021 17 commits
  3. 22 Apr, 2021 16 commits
  4. 20 Apr, 2021 3 commits