1. 17 Jan, 2017 1 commit
  2. 16 Jan, 2017 7 commits
  3. 12 Jan, 2017 2 commits
  4. 10 Jan, 2017 7 commits
  5. 09 Jan, 2017 1 commit
  6. 05 Jan, 2017 3 commits
    • Robert Knight's avatar
      Remove initial redirect when sidebar loads · 1c933e5a
      Robert Knight authored
      Avoid redirecting to '/viewer' when the sidebar loads.
      
      This redirect is unnecessary since the sidebar never changes its mode
      once loaded and it caused the viewer embedded on a page to fail to load
      when restoring a closed tab in Chrome.
      
      This may also resolve issues where the user agent disallows the
      'replaceState' call in certain situations (search prod-client reports on
      Sentry for "replaceState")
      
      Fixes #178
      1c933e5a
    • Robert Knight's avatar
      0.50.0 · 26bd2791
      Robert Knight authored
      26bd2791
    • Robert Knight's avatar
      Update Change Log · 743ce656
      Robert Knight authored
      743ce656
  7. 23 Dec, 2016 4 commits
  8. 22 Dec, 2016 1 commit
    • Robert Knight's avatar
      Display annotations in Annotations tab after timeout · cd4039ca
      Robert Knight authored
      Instead of marking annotations as orphans after the anchoring timeout
      expires, instead display them in the Annotations tab but with a visual
      indicator that they have not yet anchored. This avoids showing
      annotations that are still anchoring in the Orphans tab, which can be
      confusing when it happens in long PDF documents with many annotations.
      
       * Add an `$anchorTimeout` flag to annotations that is set if
         annotations fail to anchor within the timeout period.
      
       * Display annotations with this flag set in the Annotations tab,
         on the optimistic basis that they will eventually anchor.
      
       * When rendering annotations with this flag set, display them with
         a quote struck through (same as orphans) to indicate that they are
         pending. The visual representation of the pending state may be
         tweaked in future.
      cd4039ca
  9. 21 Dec, 2016 2 commits
  10. 20 Dec, 2016 1 commit
  11. 19 Dec, 2016 3 commits
    • Robert Knight's avatar
      Remove unused module stub · 51daa256
      Robert Knight authored
      51daa256
    • Robert Knight's avatar
      Consolidate logic for annotation <-> tab assignment · f9ee271c
      Robert Knight authored
      Previously the logic for determining which tab an annotation should appear
      in occurred both in `root-thread.js` where it was used to filter
      annotations based on the selected tab, and in `widget-controller.js` where
      it was used to switch to the tab containing a particular annotation.
      
      Consolidate all the logic for deciding which tab an annotation should
      appear in into a single module. This makes it easier to test that tab
      assignment is correct with different combinations of feature flags and
      annotation states and to add additional logic in future.
      f9ee271c
    • Robert Knight's avatar
      Move the list of connected frames to the Redux store · 5df4a9cd
      Robert Knight authored
      Move metadata about the frames that are connected to the sidebar app,
      such as the document's URL and fingerprint, to the central app state
      store.
      
      This is part of an effort to unify how important application state is
      managed.
      5df4a9cd
  12. 16 Dec, 2016 2 commits
  13. 30 Nov, 2016 3 commits
  14. 28 Nov, 2016 2 commits
    • Nick Stenning's avatar
      Remove 'defer_realtime_updates' feature flagging · fad29df7
      Nick Stenning authored
      This is now enabled by for everyone, so we don't need the feature flag
      any more.
      fad29df7
    • Robert Knight's avatar
      Speed up PDF anchoring (#171) · ff8e000e
      Robert Knight authored
      When anchoring many annotations on a PDF, the text of the same page may
      be requested many times.
      
      The text is initially fetched via an async call to
      PDFViewerApplication.pdfViewer.getPageTextContent() and the result is
      then cached for future use.
      
      Previously the cache was only updated once this expensive call
      returned a result. Consequently when anchoring many annotations at once,
      there would be a lot of unnecessary cache misses and repeated calls to
      PDFViewerApplication.pdfViewer.getPageTextContent()
      
      Fix the problem by storing a promise for the result in the cache when
      the text for a given page is requested the first time. Consequently the
      text for each page will only be fetched once.
      ff8e000e
  15. 27 Nov, 2016 1 commit
    • Robert Knight's avatar
      Use a custom element name for highlight spans · 2d971124
      Robert Knight authored
      Use the same trick that was applied to the adder in
      d9644a80 to reduce the likelihood of the
      page's own CSS styling modifying the appearance of highlights.
      
      Compared to alternative methods which would raise the precedence of
      highlight styling (inline styles, !important !all !the !things, selector
      precedence hacks), this approach is simpler as it makes the conflicting
      rule from the page's own styling not apply at all.
      
      Fixes hypothesis/h#3520
      2d971124