1. 09 Jul, 2018 2 commits
    • Robert Knight's avatar
      Add documentation for externalContainerSelector · c5a6585d
      Robert Knight authored
      Document externalContainerSelector configuration option.
      
      This is marked as experimental since it is new and may change based on
      feedback from early users (eg. Atypon).
      
      This API is also currently incomplete in that there are a number of
      additional APIs needed to fully implement a custom sidebar container
      which do not exist, eg. the ability for the host page to know when to
      show or hide the sidebar as the user interacts with highlights in the
      page.
      c5a6585d
    • Robert Knight's avatar
      Merge pull request #707 from evidentpoint/configurable-sidebar-placement · 96cce1ef
      Robert Knight authored
      `externalContainerSelector` config implementation
      96cce1ef
  2. 27 Jun, 2018 1 commit
  3. 14 Jun, 2018 10 commits
  4. 12 Jun, 2018 1 commit
    • Robert Knight's avatar
      Fix "No results for {query}" message · 01915c04
      Robert Knight authored
      Usage of `vm.search.query` in the `<sidebar-content>` template was
      incorrect. `vm.search` is always set and `query` is a function that
      returns a string, not a string.
      
      Fixes #9
      01915c04
  5. 08 Jun, 2018 4 commits
  6. 06 Jun, 2018 1 commit
    • Robert Knight's avatar
      Convert PdfSidebar to JS · 345a0599
      Robert Knight authored
      ES 6 does not provide a direct equivalent for CoffeeScript's static
      class properties so the initialization of `options` has been refactored
      to use `Object.assign()` as a more idiomatic way to combine the config
      args passed to the constructor with the defaults for `PdfSidebar`.
      345a0599
  7. 29 May, 2018 3 commits
    • Juan Corona's avatar
      Implement functionality for external container config · 37b3c617
      Juan Corona authored
      - Set a new `externalFrame` property when the external container config is provided.
      - Use the new instance var is over the existing `frame` var.
      	- This was done to isolate the new usage from the existing usage of `frame`
      	- The existing usage of `frame` applies control over the sidebar frame, which works against what we want with `externalFrame`
      - Make the uses of `frame` conditional.
      	- These are the statements that are not invoked when the external container is specified.
      	- The one case where we do want to use either frame is when emitting `onLayoutChange`
      - Refactor the Sidebar tests to test for the added implementation and usage
      37b3c617
    • Juan Corona's avatar
      Make the loading of the BucketBar and Toolbar plugins selective · 9c3fb515
      Juan Corona authored
      - Add logic that removes the plugins conditionally based on the config.
      - Move the existing logic for the `theme` config to be grouped with the above.
      - The new location for the existing logic is better for testing.
      - Add tests for the new and existing logic.
      9c3fb515
    • Juan Corona's avatar
      d9a12ac4
  8. 28 May, 2018 1 commit
  9. 25 May, 2018 4 commits
  10. 14 May, 2018 2 commits
  11. 11 May, 2018 2 commits
  12. 10 May, 2018 5 commits
  13. 09 May, 2018 2 commits
  14. 08 May, 2018 1 commit
  15. 01 May, 2018 1 commit
    • Robert Knight's avatar
      Fix test failure in Chrome caused by lack of isolation between tests · d98aff1a
      Robert Knight authored
      A `<link>` tag with a relative URL from a previous test was causing
      problems in Chrome when testing the behavior of `Document#uri` in
      documents with a non-HTTP/file `<base>`.
      
      That is an edge case which we may want to cover at some point, but the
      more significant issue is that the `Document#uri` tests were not
      isolated from the earlier ones. Modify the `createDoc` helper so that it
      uses a blank HTML document instead of using the global `document`
      object.
      d98aff1a