- 16 Jan, 2024 4 commits
-
-
Alejandro Celaya authored
-
Alejandro Celaya authored
-
Robert Knight authored
Align how `useRootThread` determines the `showTabs` argument it passes to `threadAnnotations` with the way `SidebarView` determines whether to render the tabs. The logic is not quite the same because `SidebarView` has some additional conditions related to direct-linking errors. However this has been ignored to align with the way `useRootThread` worked prior to the most recent changes. The changes here are intended to be temporary: once the new search UI is enabled for everyone, the tabs will always be shown and the logic will become much simpler.
-
Alejandro Celaya authored
-
- 15 Jan, 2024 15 commits
-
-
Robert Knight authored
These should not appear on any tab or be included in `tabCounts` output.
-
Robert Knight authored
This matches the behavior from earlier versions when tabs were shown. Unlike previously, we now always show tabs in the sidebar, so this means that conversations without a root annotation will always be hidden in this context, whereas previously they could be hidden until you performed a search, which could be confusing.
-
Robert Knight authored
The `store.clearSelection()` call currently clears the selection and also all other filters, which means that switching tabs changed several things in the UI beyond just the current tab. Change this so it just changes the tab.
-
Robert Knight authored
This makes the UI more consistent across filter active/inactive states and removes the need to show a total number of annotations in the search result summary, since that continues to be visible on the tabs when a filter is active.
-
Robert Knight authored
Previously the thread counts shown on tabs in the sidebar were computed from the full set of annotations in the store, not taking into account any filters that are active. This was acceptable because the tabs were hidden if a filter was active. However we are planning to change this and thus we need to compute tab counts that include the effects of active filters. - Change `threadAnnotations` to compute thread counts per tab, as well as the thread itself. This is done by not filtering top-level threads in `buildThread` but instead doing a filtering pass later, which also computes the thread count for each tab. - Change `SelectionTabs` to take the tab counts as a prop, instead of getting the count from the store.
-
Alejandro Celaya authored
-
Robert Knight authored
-
dependabot[bot] authored
Bumps [prettier](https://github.com/prettier/prettier) from 3.1.1 to 3.2.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/3.1.1...3.2.2) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the sentry group with 2 updates: [@sentry/browser](https://github.com/getsentry/sentry-javascript) and [@sentry/cli](https://github.com/getsentry/sentry-cli). Updates `@sentry/browser` from 7.92.0 to 7.93.0 - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/7.92.0...7.93.0) Updates `@sentry/cli` from 2.24.1 to 2.25.0 - [Release notes](https://github.com/getsentry/sentry-cli/releases) - [Changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-cli/compare/2.24.1...2.25.0) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: sentry - dependency-name: "@sentry/cli" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: sentry ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the rollup group with 1 update: [rollup](https://github.com/rollup/rollup). Updates `rollup` from 4.9.4 to 4.9.5 - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v4.9.4...v4.9.5) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-patch dependency-group: rollup ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [npm-packlist](https://github.com/npm/npm-packlist) from 8.0.1 to 8.0.2. - [Release notes](https://github.com/npm/npm-packlist/releases) - [Changelog](https://github.com/npm/npm-packlist/blob/main/CHANGELOG.md) - [Commits](https://github.com/npm/npm-packlist/compare/v8.0.1...v8.0.2) --- updated-dependencies: - dependency-name: npm-packlist dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the eslint group with 2 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser). Updates `@typescript-eslint/eslint-plugin` from 6.18.0 to 6.18.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.18.1/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.18.0 to 6.18.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.18.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: eslint - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: eslint ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the babel group with 1 update: [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env). Updates `@babel/preset-env` from 7.23.7 to 7.23.8 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.8/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: babel ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1531.0 to 2.1536.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1531.0...v2.1536.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@npmcli/arborist](https://github.com/npm/cli/tree/HEAD/workspaces/arborist) from 7.2.2 to 7.3.0. - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/workspaces/arborist/CHANGELOG.md) - [Commits](https://github.com/npm/cli/commits/v7.3.0/workspaces/arborist) --- updated-dependencies: - dependency-name: "@npmcli/arborist" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 12 Jan, 2024 8 commits
-
-
Alejandro Celaya authored
-
Alejandro Celaya authored
-
Alejandro Celaya authored
-
Alejandro Celaya authored
-
Alejandro Celaya authored
-
Alejandro Celaya authored
-
Alejandro Celaya authored
-
dependabot[bot] authored
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](https://github.com/pallets/jinja/compare/3.1.2...3.1.3) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 11 Jan, 2024 3 commits
-
-
Alejandro Celaya authored
-
Alejandro Celaya authored
-
Alejandro Celaya authored
-
- 10 Jan, 2024 2 commits
-
-
Alejandro Celaya authored
-
dependabot[bot] authored
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.8 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.8...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 09 Jan, 2024 3 commits
-
-
Robert Knight authored
This should avoid a conflict when uploading files to Sentry due to having two versions that are the same. It also makes it easy to verify that the client being served by staging.hypothes.is is the correct one.
-
Robert Knight authored
This is a copy-and-paste of the `release-qa` job configuration, with "qa" replaced by "staging". This is part of the new staging deployment of h. It initially re-uses the AWS / Sentry auth from the existing GitHub "qa" environment in the client repo. See https://github.com/hypothesis/playbook/issues/1519.
-
Alejandro Celaya authored
-
- 08 Jan, 2024 5 commits
-
-
Alejandro Celaya authored
-
Robert Knight authored
This unfortunately doesn't catch mistakes where incorrect property names are used because TS allows excess properties, but it does at least document what the expected keys are.
-
Robert Knight authored
- Try to better explain the context in which each of the filters is used - Re-organize the state fields so that user-applied filters are at the top, followed by the focus filter state
-
Robert Knight authored
Store the focus filter activation state as a set of active filters (eg. `{"user", "page"}`) instead of a boolean. This will allow the filters to be toggled independently in future. To support the existing UI where there is only a single toggle control, `toggleFocusMode` retains the ability to toggle all configured filters. Once the new search UI is rolled out for everyone, we can probably remove this.
-
Alejandro Celaya authored
-