Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 28 May, 2020 6 commits
  3. 27 May, 2020 5 commits
  5. 26 May, 2020 7 commits
  7. 25 May, 2020 8 commits
  9. 21 May, 2020 10 commits
  11. 20 May, 2020 4 commits
    • Lyza Danger Gardner's avatar
      Remove redundant “Select” and “tabs” verbiage · be001f85
      Lyza Danger Gardner authored
      be001f85
    • Robert Knight's avatar
      When multiple unsaved annotations exist, scroll to the newest · bda834da
      Robert Knight authored 
      It is possible for multiple unsaved annotations to exist if a user
creates a new annotation, enters some text but does not save, and then
creates another new annotation. In this case, make the thread list
always scroll to the newest. A side effect of the implementation is that
if this second annotation is then deleted or saved, the thread list will
scroll back to the previous unsaved annotation. This behavior seems
useful, so I've kept it.
      bda834da
    • Robert Knight's avatar
      Replace the `BEFORE_ANNOTATION_CREATED` event · 75a0e8aa
      Robert Knight authored 
      The `BEFORE_ANNOTATION_CREATED` event was used for two purposes:

 1. Invoke `annotationsService.create(...)` to create the annotation in
    the sidebar.
 2. Scroll the newly created annotation into view

Resolve (1) by calling `annotationsService.create` directly from the
`frameSync` service and resolve (2) by watching for changes to
`unsavedAnnotations()` in the store and scrolling to the new annotation
when it appears.

There is one functional change which is that replies will be scrolled
into view, as this seems like a useful behavior if the user clicks the
"Reply" button for a thread and the input field appears below the bottom
of the screen.
      75a0e8aa
    • Lyza Gardner's avatar
      Merge pull request #2182 from hypothesis/improved-loading-state · 3ba68201
      Lyza Gardner authored 
      Improve loading state for LMS, all users
      3ba68201