- 07 Feb, 2015 2 commits
-
-
Randall Leeds authored
Keep the AppController away from the root scope and just emit the lifecycle events for the services. Instantiate AnnotationUIController with proper injection. Handle digests in the cross-frame service.
-
Randall Leeds authored
-
- 05 Feb, 2015 1 commit
-
-
Aron Carroll authored
-
- 04 Feb, 2015 37 commits
-
-
Aron Carroll authored
This keeps it consistent with the CrossFrame service in the angular application. Also appropriate as the plugin handles more than just setting up the bridge.
-
Aron Carroll authored
-
Aron Carroll authored
-
Aron Carroll authored
-
Aron Carroll authored
As this channel is outside of the angular framework we need to let it know that it's internal state may have changed and to re-run it's watchers.
-
Aron Carroll authored
This fixes some issues where the AppController was still manipulating the local scope and causing the UI to become out of sync.
-
Aron Carroll authored
i These also now always set new map instances so that the angular watcher picks up changes without having to do a deep comparison.
-
Aron Carroll authored
These were the wrong way around.
-
Aron Carroll authored
We need to export them for access in the tests, and we don't really want them in the global scope (window) so Annotator.Plugin.Guest seems like a good compromise.
-
Aron Carroll authored
Now consistent with the other cross frame objects in that the optional "options" object is provided last after required arguments.
-
Aron Carroll authored
There is no need for the called to know what objects are being instantiated inside the Bridge plugin.
-
Aron Carroll authored
-
Aron Carroll authored
This avoids the confusion of having a property called panel that refers to an instance of Bridge.
-
Aron Carroll authored
This prevents other objects reaching in and calling methods further down the chain. If a method needs to be called then it should be proxied by the Guest object.
-
Aron Carroll authored
-
Aron Carroll authored
-
Aron Carroll authored
-
Aron Carroll authored
-
Aron Carroll authored
-
Aron Carroll authored
-
Aron Carroll authored
-
Aron Carroll authored
-
Gerben authored
-
Gerben authored
-
Gerben authored
-
Aron Carroll authored
-
Aron Carroll authored
-
Aron Carroll authored
Unclear why it's needed, might be used for file:// endpoints...
-
Aron Carroll authored
* Now throw an error if startDiscovery is called twice. * Throw an error if two server instances message each other. * Remove the context of the onDiscovery callback.
-
Aron Carroll authored
* Remove the jQuery dependency. * Pass in window as an argument to the constructor. * Move defaults off the prototype and onto the constructor fn.
-
Aron Carroll authored
-
Aron Carroll authored
-
Aron Carroll authored
-
Aron Carroll authored
We nullify the default options to ensure that no objects can be shared between instances and remove the no-op onConnect callback.
-
Aron Carroll authored
This was fixed by 8e1c52f7 and moving bootstrap into app.coffee
-
Aron Carroll authored
-
Aron Carroll authored
The current implementation assumed that the setupAnnotation method needed to do a large amount of work and so batched the calls. Our sidebar no-ops this method so we can effectively get rid of the setup method and batch calls.
-