group-list-item.js
group-list-section.js
group-list.js

Typechecking now completes for enough of the `src/` directory that we
can enable checking for all .js files except for tests and a small
number of files in `src/sidebar.

CoffeeScript imports are marked as expected errors for the moment. They
will be checked once those files are converted.

Flipgrid fixed an issue on their end that required us to make the iframe
for Flipgrid embeds taller than the actual content. This commit removes
the custom aspect ratio so that these videos will use the 16:9 default.

Tested by pasting this link into an annotation: https://flipgrid.com/s/030475b8ceff

Slack thread: https://hypothes-is.slack.com/archives/C1M8NH76X/p1596723935386100

`clearSelection` does the same thing

Typecheck the class that reads metadata from HTML documents and attaches
it to annotations as the `annotation.document` property.

This resulted in a few minor corrections to the `DocumentMetadata` type
in `src/types/annotator.js`.

- new-note-btn.js
- search-status-bar.js
- selection-tabs.js
- annotation-action-bar.js
- annotation-quote.js

Fix an a11y issue reported by axe-core [1] by adding an aria-label
attribute to several links that did not have text content. These links
all have `title` attributes but axe v4.0.0 does not consider that a valid
label.

[1] https://dequeuniversity.com/rules/axe/4.0/link-name?application=axeAPI

Bumps [axe-core](https://github.com/dequelabs/axe-core) from 3.5.5 to 4.0.0.
- [Release notes](https://github.com/dequelabs/axe-core/releases)
- [Changelog](https://github.com/dequelabs/axe-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/dequelabs/axe-core/compare/v3.5.5...v4.0.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Add `src/types/pdfjs.js` module which defines the subset of the PDF.js
viewer API that the client actually uses and make use of it in
`src/annotator/anchoring/pdf.js` and `src/annotator/plugin/pdf-metadata.js`
to typecheck these files.

As well as helping to catch errors and JSDoc mistakes in these files,
this should also make future PDF.js upgrades easier because we can see
what PDF.js APIs the client actually relies on.

The `MenuItem` component never used this prop. It was passed by mistake
in `SortMenu` as a duplicate of the `label` prop.

Enable typechecking of most JS files in src/annotator except for:

 - The entrypoint index.js file. This cannot be usefully checked since
   it imports many CoffeeScript files
 - pdf-sidebar.js - This extends a class currently written in
   CoffeeScript
 - src/annotator/anchoring/pdf.js - This requires types for various
   PDF.js globals to be defined
 - The `annotator/plugin` directory

- Fix typing for createSelector() wrapped selectors. (use @type, not @return)
- Fix `FrameInfo` type and use it. Previously it was orphaned.

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.10.5 to 7.11.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.11.0/packages/babel-core)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bumps [karma](https://github.com/karma-runner/karma) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v5.1.0...v5.1.1)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 9.8.5 to 9.8.6.
- [Release notes](https://github.com/postcss/autoprefixer/releases)
- [Changelog](https://github.com/postcss/autoprefixer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/postcss/autoprefixer/compare/9.8.5...9.8.6)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bumps [scroll-into-view](https://github.com/KoryNunn/scroll-into-view) from 1.14.2 to 1.15.0.
- [Release notes](https://github.com/KoryNunn/scroll-into-view/releases)
- [Commits](https://github.com/KoryNunn/scroll-into-view/commits)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bumps [fetch-mock](https://github.com/wheresrhys/fetch-mock) from 9.10.5 to 9.10.6.
- [Release notes](https://github.com/wheresrhys/fetch-mock/releases)
- [Commits](https://github.com/wheresrhys/fetch-mock/compare/v9.10.5...v9.10.6)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bumps [browserify](https://github.com/browserify/browserify) from 16.5.1 to 16.5.2.
- [Release notes](https://github.com/browserify/browserify/releases)
- [Changelog](https://github.com/browserify/browserify/blob/master/changelog.markdown)
- [Commits](https://github.com/browserify/browserify/compare/v16.5.1...v16.5.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bumps [mocha](https://github.com/mochajs/mocha) from 8.0.1 to 8.1.0.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mochajs/mocha/compare/v8.0.1...v8.1.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bumps [eslint](https://github.com/eslint/eslint) from 7.5.0 to 7.6.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.5.0...v7.6.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.720.0 to 2.726.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js/compare/v2.720.0...v2.726.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.10.4 to 7.11.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.11.0/packages/babel-preset-env)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

The way that the search interface is currently implemented,
clicking on the "search" icon in the top bar actually
submits the search form (with an empty query).

Ignoring empty queries if a query has not yet been set
alleviates "searching" for nothing.

This also prevents expanded threads from being re-collapsed
when clicking on the search icon.