- 10 Apr, 2014 1 commit
-
-
csillag authored
-
- 06 Apr, 2014 1 commit
-
-
Randall Leeds authored
More minor tidy of OSX docs
-
- 05 Apr, 2014 2 commits
-
-
csillag authored
-
gergely-ujvari authored
With the page search you can search for the username, but for redacted annotation the user filter gives back a null as a username, and we tried to convert this to lowercase() Fixes #1160
-
- 02 Apr, 2014 9 commits
-
-
gergely-ujvari authored
Since, for document view to had to add the new annotation manually to the rootScope.annotations, we have forgotten to check whether is it a reply or not. Now replies are not added. The original error also went away when the view(scope) was changed.
-
Randall Leeds authored
-
Randall Leeds authored
When we deploy as an extension the application baseURI is the URL of the backend, rather than the extension. As a result, templates are relative to this location. Even though we inline the templates in the extension bundle, we have to ensure the compilation isn't blocked by strict contextual escaping.
-
gergely-ujvari authored
When we sacked the scope search facets and rely on rootScope.annotations the replies were no longer tested as possible search results. It is now restored.
-
Randall Leeds authored
This was causing a race condition on app startup. Now, the worst that happens is the flash message shows in the sidebar.
-
gergely-ujvari authored
If not doing this the rootScope.predicate etc. variables are not set and angular silently fails sorting Fixes #1150
-
gergely-ujvari authored
The rootScope.annotations was not refreshed when a new real-time annotation arrived, so for comments and document view we have to insert the annotation there manually Fixes #1149
-
gergely-ujvari authored
As for the sort the page search works with threads instead of annotations so the directive should look for either annotation or thread.message in the scope Page search focuses annotations when it opens them. Thx @csillag for the help
-
gergely-ujvari authored
Originally page search was not prepared for the sort viewState, now it is. For this, the applySort() was refactored to use the rootScope instead of the scope and produces both the predicate for the viewer and for the page search Fixes #1148
-
- 01 Apr, 2014 27 commits
-
-
csillag authored
-
gergely-ujvari authored
Page search can now search within all the scopes. Even dynamic mode works when search results are recalculated during scrolling. Fixes #1094
-
Randall Leeds authored
-
csillag authored
-
gergely-ujvari authored
This is the final piece that is needed to complete the current issues with page search quote. I'm going to reference both issues because this and the previous commits were required to fix them. Fixes #1095 Fixes #1103
-
csillag authored
-
gergely-ujvari authored
The previous fix introduced handling the page search quote search facets as list. However the empty list was not handled well. This correct that.
-
csillag authored
-
csillag authored
-
gergely-ujvari authored
Collect all quote items for Page search. I'll merge my PR because it is an easy fix. Not affecting anything else.
-
csillag authored
-
gergely-ujvari authored
Originaly visual-search automatically collects the text fields into one space separated list. But it does not do the same for any other field type, so we have to collect our search facet's values for quotes manually. This changes now expects that our quote search results are a list and handles it like this all the way. (Even for generating the highlightQuote attribute) Now if multiple query facets are given it assumes an 'AND' relation between them. A nice future task will be makes this page search configurable as like the stream facets, but that should come after viewer/page search unification
-
Randall Leeds authored
Introduce focus
-
csillag authored
-
csillag authored
-
csillag authored
Missing: search magic
-
csillag authored
-
Randall Leeds authored
I think this better ensures #1135 is fixed cleanly. Before, the controls might hide after the timeout, but the user may be on their way to click it. Now, everything goes through showViewSort, and it manages timeout cancellation. Also, moved the view and sort controls out to the app.pt. Because they're essentially global now, and we should move to kill the viewer, editor, search distinction anyway.
-
Randall Leeds authored
Also, use destructuring while we're here for readibility
-
Randall Leeds authored
-
Randall Leeds authored
Coffee always breaks switch cases
-
csillag authored
-
csillag authored
-
csillag authored
-
csillag authored
-
csillag authored
-
csillag authored
Moved `applyView`, `applySort` and `viewState` to the root scope. Fixes #1131. Fixes #1132.
-