- 11 May, 2021 9 commits
-
-
Robert Knight authored
Part of https://github.com/hypothesis/client/issues/3298 Convert the `streamer` service to an ES class, modernize the code (functions => arrow functions, Promise chains => async/await) and improve the class documentation. There are no significant changes to the internal logic or API.
-
Robert Knight authored
This makes it more obvious what is going on at a glance. Refactoring the code in this way revealed to TS a hazard where `newGroupId` could, at least based only on local reasoning, be null. In practice this shouldn't happen due to the contexts when the method is called, but I've added a check to be safe and keep TS happy.
-
Robert Knight authored
Re-order the arguments based on an alphabetic sorting of the `@param` lines, which results in sorting by import path. This will make it more obvious where to slot in any new dependencies in future. Also sort the field initialization to match.
-
Robert Knight authored
-
Robert Knight authored
- Convert the `groups` service to an ES class and the many closures in the constructor to private or public methods. - Remove the unused `all` and `get` methods of the groups service. These were trivial wrappers around store methods. UI components should use the store methods directly.
-
Robert Knight authored
- Clarify what a "non-file URL" means and add an additional test case for HTTPS URLs - Add a comment to clarify the precedence order of titles. The tests could more directly check that the expected precedence order is respected, but the logic here is expected to change very soon, so just add a comment for now.
-
Robert Knight authored
Convert remaining promise chains in `PDFMetadata` tests to async/await.
-
Robert Knight authored
- Convert promise chains to async/await - Add missing tests to check that the PDF URL and fingerprint URL appear in the object returned by `getMetadata`. These were previously tested indirectly in other tests. - Change tests to only check the specific properties of the returned object that are of interest. This reduces the changes needed when tests change unrelated parts of the output.
-
Robert Knight authored
Refactor the setup steps in PDFMetadata tests to make it easier to customize the PDF metadata exposed by the fake PDF.js environment. Instead of creating a fake `PDFViewerApplication` and `PDFMetadata` instance before each test, provide a helper function that creates both using the provided metadata.
-
- 10 May, 2021 19 commits
-
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.3.5 to 6.3.6. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/6.3.5...6.3.6) Signed-off-by: dependabot[bot] <support@github.com>
-
Eduardo Sanz García authored
-
Eduardo Sanz García authored
-
dependabot[bot] authored
Bumps [prettier](https://github.com/prettier/prettier) from 2.2.1 to 2.3.0. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/2.2.1...2.3.0) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [katex](https://github.com/KaTeX/KaTeX) from 0.13.5 to 0.13.9. - [Release notes](https://github.com/KaTeX/KaTeX/releases) - [Changelog](https://github.com/KaTeX/KaTeX/blob/master/CHANGELOG.md) - [Commits](https://github.com/KaTeX/KaTeX/compare/v0.13.5...v0.13.9) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [codecov](https://github.com/codecov/codecov-node) from 3.8.1 to 3.8.2. - [Release notes](https://github.com/codecov/codecov-node/releases) - [Changelog](https://github.com/codecov/codecov-node/blob/master/CHANGELOG.md) - [Commits](https://github.com/codecov/codecov-node/compare/v3.8.1...v3.8.2) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.14.0 to 7.14.1. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.14.1/packages/babel-preset-env) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [postcss](https://github.com/postcss/postcss) from 8.2.13 to 8.2.14. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.2.13...8.2.14) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.897.0 to 2.903.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.897.0...v2.903.0) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [eslint-config-hypothesis](https://github.com/hypothesis/frontend-toolkit) from 2.4.0 to 2.5.0. - [Release notes](https://github.com/hypothesis/frontend-toolkit/releases) - [Commits](https://github.com/hypothesis/frontend-toolkit/commits) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [gulp-replace](https://github.com/lazd/gulp-replace) from 1.1.2 to 1.1.3. - [Release notes](https://github.com/lazd/gulp-replace/releases) - [Commits](https://github.com/lazd/gulp-replace/compare/v1.1.2...v1.1.3) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [mocha](https://github.com/mochajs/mocha) from 8.3.2 to 8.4.0. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v8.3.2...v8.4.0) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [eslint](https://github.com/eslint/eslint) from 7.25.0 to 7.26.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v7.25.0...v7.26.0) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 9.0.0 to 9.1.1. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](https://github.com/puppeteer/puppeteer/compare/v9.0.0...v9.1.1) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [npm-packlist](https://github.com/npm/npm-packlist) from 2.1.5 to 2.2.2. - [Release notes](https://github.com/npm/npm-packlist/releases) - [Commits](https://github.com/npm/npm-packlist/compare/v2.1.5...v2.2.2) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.11.2 to 3.12.1. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.12.1/packages/core-js) Signed-off-by: dependabot[bot] <support@github.com>
-
Eduardo Sanz García authored
I removed a @ts-expect-error and tight some types. I remove the returned `provider` property from the `authStateFromProfile` function as it was not used.
-
dependabot[bot] authored
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.23 to 0.7.28. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Commits](https://github.com/faisalman/ua-parser-js/compare/0.7.23...0.7.28) Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](https://github.com/npm/hosted-git-info/compare/v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <support@github.com>
-
- 07 May, 2021 5 commits
-
-
Robert Knight authored
This ensures that the component doesn't attempt to call the prop and use the result.
-
Robert Knight authored
As noted in PR review, checking for a valid annotation first seems more sensible.
-
Robert Knight authored
-
Robert Knight authored
Previously all components that used injected services did not have their usage type-checked because `withServices` returned `any`. This commit refactors the API of `withServices` to make it easier to typecheck and adds types. The major API change is that the list of injected services is now passed as a second argument to `withServices` rather than by setting an `injectedProps` property on the component. This makes it easy to infer that the component returned by `withServices(Widget, ['serviceA', 'serviceB'])` has the same props as `Widget` but without `serviceA` or `serviceB`. Making these changes also turned up a handful of mistakes in existing types which are fixed here: - Correct `auth` type used by `HelpPanel` - Correct type of `thread` prop used by `ThreadCard` - Correct optionality of boolean arguments in callbacks to `Excerpt` - Change `showActions` logic in `Annotation` to make it more obvious to TS that the actions are only shown when there is an annotation - Remove unused props passed to `GroupList` Additionally there was a type error with TopBar's `auth` prop which is less trivial to fix, so I have punted it to a future commit.
-
Robert Knight authored
The type of the `props` argument to `TopBar` was not specified, so its props were not type-checked. Specifying a type for `props` turned up several mistakes in other types. - Specify the type of the `props` object so that the props are actually type-checked - Add missing `status` field to `AuthState` type - Correctly set the optionality of various props
-
- 06 May, 2021 6 commits
-
-
Robert Knight authored
This reverts commit df0084c0.
-
Jon Betts authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Switch the markdown parser to the one recommended by the current Sphinx documentation [1]. This fixes an error parsing Markdown code blocks in `adr-003.md` when running `make checkdocs` and makes this file show up under "Architecture Decision Records" in the generated docs. The `requirements/docs.txt` file was updated by directly running `.tox/docs/bin/pip-compile -r requirements/docs.in`. [1] https://www.sphinx-doc.org/en/master/usage/markdown.html
-
Jon Betts authored
* This adds pinned versions of the docs dependencies, so they don't drift between local and CI * This is managed with `hdev requirements` so support for that has been added * Using the pyenv integration we have elsewhere so tox tracks the versions in the version file
-
- 03 May, 2021 1 commit
-
-
Robert Knight authored
-