Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 15 Sep, 2020 10 commits
  3. 14 Sep, 2020 1 commit
    • Robert Knight's avatar
      Fix real-time update action processing · 9479612f
      Robert Knight authored 
      When store modules were refactored to only receive their local state in
selectors, the code in `store/modules/real-time-updates` which directly
uses selectors from other modules rather than calling
`store.<selectorMethod>(...)` was not updated to pass in the appropriate
part of the state.

Fixing this resolves two problems:

 - An error when processing notifications of deleted annotations from
   the server. These notifications are currently not getting delivered
   due to a server-side issue (see https://github.com/hypothesis/h/pull/6214).

 - Filtering notifications of new or updated annotations not excluding
   annotations from groups that are not currently focused.

   Fixing this second issue has the side effect that it _appears_ to fix
   https://github.com/hypothesis/support/issues/137 from the user's
   point of view. I say _appears to_ because the backend is still
   incorrectly delivering notifications that the user shouldn't be able
   to see. That is fixed by https://github.com/hypothesis/h/pull/6202
      9479612f
  5. 11 Sep, 2020 3 commits
  7. 10 Sep, 2020 1 commit
    • Robert Knight's avatar
      Convert `Delegator` base class to JS · 2e0eee75
      Robert Knight authored 
      Convert the `Delegator` base class to JS and rewrite the documentation
to match current functionality and usage. Also simplify the `options`
initialization and add a note about why the constructor reads
`this.options` before assigning it.

I tried to convert the `Plugin` class as well but encountered an issue
with interaction between Babel-compiled derived classes and CoffeeScript
sub-classes (in particular, the `BucketBar` class), so it looks like
`Plugin` sub-classes will need to be converted first.
      2e0eee75
  9. 09 Sep, 2020 2 commits
  11. 08 Sep, 2020 15 commits
  13. 07 Sep, 2020 4 commits
  15. 03 Sep, 2020 3 commits
    • Lyza Danger Gardner's avatar
      Adjust keyboard interaction with TagEditor · 0b9a114f
      Lyza Danger Gardner authored
      0b9a114f
    • Lyza Danger Gardner's avatar
      Add list-item formatter for suggested tags list · b32cbefb
      Lyza Danger Gardner authored 
      Help user see what part of an entered tag is a match for a suggested tag
      b32cbefb
    • Lyza Danger Gardner's avatar
      Suggested tag matching should not use lookback · b8ad9722
      Lyza Danger Gardner authored 
      Change the matching logic for determining whether a given suggested tag
(`tag`) matches the currently-typed tag field text (`query`).

Formerly, `tag` would match `query` if `tag` were a substring of `query`
in any position. However, this creates a lot of noise in the matches and
is not commonly what folks are after.

Now, `tag` will match `query` if:

* `tag` starts with `query` OR
* `query` occurs within `tag` after a word boundary or a non-word
   character

Thus, a `query` of "app":

* Would match the `tag` "apple"
* Would match the `tag` "crab apple" ("app" occurs after a word boundary)
* Would match the `tag` "crab.apple" ("app" occurs after non-word char)
* Would NOT match the `tag` "crabapple"
      b8ad9722
  17. 02 Sep, 2020 1 commit
    • Kyle Keating's avatar
      Add nodeFromXPath to range-js and refactor tests · 1cc4e1ca
      Kyle Keating authored 
      - Refactor `range-js-test` and remove specific testing of internal functions such as `findChild` and `nodeFromXPathFallback`.

- `nodeFromXPath` ported code does not contain any code path for XML handling as the coffeescript previously did. This code was however previously untested and difficult to reproduce in practice. It was likely was never or rarely used and is over 6 years old.
      1cc4e1ca