- 20 Nov, 2018 4 commits
-
-
jenkins-hypothesis authored
-
Robert Knight authored
Enable third-party authorities to globally disable annotation share links
-
Robert Knight authored
In the context of the LMS app, the client is embedded inside a Via iframe, which is inside an LMS app iframe, which is inside Canvas. There is currently no mechanism in place to propagate the focused annotation down the frame hierarchy. As a result, share links show up but do not work. As a simple way to resolve that for an initial version of the LMS app, provide it with a way to globally disable annotation share links. In future we may move this responsibility to the "h" service, so that the availability (or not) of share links is correctly reflected in h API responses. Part of https://github.com/hypothesis/product-backlog/issues/843
-
jenkins-hypothesis authored
-
- 19 Nov, 2018 6 commits
-
-
Robert Knight authored
Support recent versions of PDF.js
-
Robert Knight authored
Recent versions of PDF.js emit a "documentloaded" event when the document finishes loading. Older versions emit "documentload". Listen for both events to support both versions.
-
Robert Knight authored
`PDFViewerApplication.documentFingerprint` was removed in recent versions of PDF.js [1]. This issue causes loading the bookmarklet into Firefox 63+ to fail because the client thinks the PDF is still loading. `PDFViewerApplication.pdfDocument.fingerprint` is the replacement mentioned in the commit that removed the property and it also appears to be more clearly a part of PDF.js' documented API. This change is backwards-compatible with the version of PDF.js that currently ships with Via. [1] https://github.com/mozilla/pdf.js/commit/e522b2d87e8eb3d4eb8a391a098a0f6f157e8c12
-
Robert Knight authored
Use a class which provides a consistent fake PDFViewerApplication implementation for use by different PDF metadata tests. This will make it easier to change the fake in order to reflect changes in PDF.js' API, or the parts of it that we use.
-
Robert Knight authored
Fix build under Node 11
-
Robert Knight authored
Upgrade `natives` indirect dependency using method described at https://github.com/yarnpkg/yarn/issues/4986#issuecomment-395036563. See also: https://github.com/isaacs/natives/issues/14
-
- 13 Nov, 2018 2 commits
-
-
Robert Knight authored
WIP bot configuration
-
Robert Knight authored
This is an attempt to prevent accidental merging of fixup commits. See https://github.com/wip/app#configuration
-
- 08 Nov, 2018 13 commits
-
-
jenkins-hypothesis authored
-
Robert Knight authored
Use atomic git push during release process
-
Robert Knight authored
Ensure that the release tag is only pushed to GitHub if the release commit can also be pushed to master. We are likely to change the release process soon to avoid the need to push to master at all (see https://github.com/hypothesis/client/issues/810) but in the meantime this prevents a scenario where: - A tag vX.Y.Z gets created - The package version is still at X.Y.(Z-1) on master - Subsequent builds of master fail because they try and fail to create a tag vX.Y.Z which already exists
-
jenkins-hypothesis authored
-
Robert Knight authored
Disable CoffeeScript support when building sidebar application
-
Robert Knight authored
All of the modules and tests for the sidebar app that were written in CoffeeScript have either been removed or converted to JS. Disable CoffeeScript support when building the sidebar bundle and stop searching for tests written in CoffeeScript in the src/shared/ and src/sidebar directories.
-
Robert Knight authored
Rewrite used parts of stream-filter.coffee in JS
-
jenkins-hypothesis authored
-
Sean Hammond authored
Convert discovery.coffee to JS
-
Sean Hammond authored
Convert shared/discovery tests to JS
-
Robert Knight authored
Add `make docs` and `make checkdocs`
-
Robert Knight authored
Add postMessage config delivery example page
-
Sean Hammond authored
Convert viewFilter tests to JS
-
- 07 Nov, 2018 8 commits
-
-
Sean Hammond authored
Deleted the "docs for how to build the docs" since this is now just a simple `make docs`, as for all our projects.
-
Robert Knight authored
`setMatchPolicyIncludeAny` no longer exists and is not needed since it is the _only_ match policy.
-
Robert Knight authored
This test case reproduces usage of `streamFilter` in annotation-viewer-content, where the operator is "equals" not "exactly".
-
jenkins-hypothesis authored
-
Robert Knight authored
-
Robert Knight authored
Remove support for real-time updates in the /stream view
-
Robert Knight authored
It is not particularly clear from the naming of these modules what they are for and how they relate to things the user can do in the application. Add some comments to clarify this.
-
Robert Knight authored
Convert the tests for the `viewFilter` class to JS. This is mostly a straightforward conversion except that `viewFilter.fields` has been made a private variable and the direct tests for ithave been removed, since the contents of this field were an implementation detail of the class.
-
- 06 Nov, 2018 3 commits
-
-
Robert Knight authored
This is straight manual conversion of tests for the `Discovery` class to JS.
-
Robert Knight authored
Add notes to `Discovery` class docs that provide an overview of the current discovery protocol.
-
jenkins-hypothesis authored
-
- 05 Nov, 2018 3 commits
-
-
Hannah Stepanek authored
Adjust spinner positioning and convert to component
-
Robert Knight authored
We need to fix these, but for now I'm just making a note about the issue.
-
Robert Knight authored
- Convert `Discovery` class to JS and improve the documentation. This is a manual conversion. - Rename private `_generateToken` method to `generateToken` because it is currently used by cross-frame.coffee. It should really be a utility method or cross-frame.coffee could use a different method to generate the ID.
-
- 02 Nov, 2018 1 commit
-
-
Robert Knight authored
Port stream-filter.coffee to JS and add tests, but only for the functionality that we actually still use in the app. Following the removal of support for real-time updates in the stream, the websocket is only configured to filter by URI, annotation ID or reply IDs ("references") in the sidebar and standalone annotation viewer.
-