- 28 Nov, 2014 4 commits
-
-
Aron Carroll authored
Consistent names for focusing on annotations.
-
csillag authored
-
gergely-ujvari authored
Remove some dead code
-
csillag authored
-
- 27 Nov, 2014 5 commits
-
-
gergely-ujvari authored
Improve visual diff code
-
Aron Carroll authored
Remove the gray background from annotation cards on hover.
-
csillag authored
- Simplify a check for an error condition - Add a test case to avoid regressing the same error
-
csillag authored
As discussed in #1634
-
csillag authored
When creating a reply, there was an exception on the console, because the target list is empty, and some code was not prepared for that. This takes care of that.
-
- 26 Nov, 2014 15 commits
-
-
Gergely Ujvari authored
Fix #1661
-
Randall Leeds authored
[WIP] Restore feature to scroll for annotations
-
csillag authored
-
Dan Whaley authored
Reposition and style show differences checkbox
-
RawKStar77 authored
-
Randall Leeds authored
[WIP] Style the visual diff support
-
csillag authored
Clicking on an annotation card will bring (one of the) highlights belonging to that annotation into the view in the document.
-
Aron Carroll authored
Restore visual diff to original behaviour.
-
csillag authored
... by using ES5 sweetness.
-
csillag authored
-
csillag authored
Remove the unnecessary per-target hasDiff flag. Extract the code for calculating the hasDiff/showDiff flags into a separate method.
-
csillag authored
Now there are separate test cases for: - A single target with no diff - A single target with some diff - A single target with some diff, which is case only - Multiple targets, some with diffs - Multiple targets, some with diffs, but only in case Furthermore, the used sample diff strings actually look like real diff strings, for better readibility. Also, removed some useless lines from the code. (Thx @aron for all the suggestions.)
-
gergely-ujvari authored
Fix holes in message threads
-
csillag authored
-
csillag authored
This restores the following corner case: When there is a difference, but it's only about the case of the characters, don't want to show the visual diff by default, but we offer the feature to the user. I also updated the tests the reflect the specs.
-
- 25 Nov, 2014 2 commits
-
-
Randall Leeds authored
-
Aron Carroll authored
-
- 24 Nov, 2014 3 commits
-
-
Aron Carroll authored
-
Aron Carroll authored
This will now always keep the branch unless the thread has no message and no children.
-
Aron Carroll authored
With the messageThread methods. This allows methods to be overridden by the object itself.
-
- 23 Nov, 2014 1 commit
-
-
Randall Leeds authored
onSetTool calls setVisibleHighlights so this is no longer needed.
-
- 22 Nov, 2014 10 commits
-
-
Randall Leeds authored
- Fix a typo where a closure was unbound - Always set target.hasDiff rather than having it be sometimes undefined and sometimes true. Thanks @aron
-
Randall Leeds authored
-
Randall Leeds authored
Move the updateTimestamp function into the controller and call it when render is called. If it is the first time, invoke it with a flag that causes it to call itself, otherwise it will only update once.
-
Randall Leeds authored
[WIP] Resurrect the removed visual diff support
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
Rather than watching a bunch of subproperties, the most complex of which are the targets, deep watch the whole annotation. The targets were being deep watched already. This just seems much easier and clearer than debouncing the render calls, and scales to whatever properties much change in the future. We'll re-evaluate if this becomes a bottleneck.
-
Randall Leeds authored
The pattern of comparing the new value passed to a watcher with the old value is idiomatic angular for avoiding the first digest. Instead, the first digest is covered by the watch on the model reference identity. After the initial rendering, the model will not change but the other properties may, at which point re-rendering will occur.
-
Randall Leeds authored
-
Randall Leeds authored
-