- 26 May, 2020 5 commits
-
-
Kyle Keating authored
Update 3 config keys - `allowLeavingGroups` - `groups` when used with “$rpc:requestGroups” value - `requestConfigFromFrame`
-
Robert Knight authored
Bump chance from 1.1.5 to 1.1.6
-
Robert Knight authored
Remove `OAUTH_TOKENS_CHANGED` event
-
Robert Knight authored
Remove unused diff-match-patch dependency
-
Robert Knight authored
We don't use this package directly any more, although there is still a transitive dependency on it via dom-anchor-text-quote.
-
- 25 May, 2020 3 commits
-
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.679.0 to 2.683.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.679.0...v2.683.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 17.9.1 to 17.9.2. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v17.9.1...v17.9.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [chance](https://github.com/chancejs/chancejs) from 1.1.5 to 1.1.6. - [Release notes](https://github.com/chancejs/chancejs/releases) - [Commits](https://github.com/chancejs/chancejs/compare/1.1.5...1.1.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 21 May, 2020 10 commits
-
-
Lyza Gardner authored
Co-authored-by: Kyle Keating <kkeating@hypothes.is>
-
Lyza Gardner authored
Co-authored-by: Kyle Keating <kkeating@hypothes.is>
-
Lyza Gardner authored
* Add `aria-expanded` to sidebar show/hide button * Add axe test to annotator toolbar component Co-authored-by: Kyle Keating <kkeating@hypothes.is>
-
Lyza Gardner authored
Use `aria-expanded` instead of `aria-pressed` per a11y audit
-
Robert Knight authored
-
Robert Knight authored
Remove the last remaining use of the `$rootScope` service to broadcast / subscribe to the `OAUTH_TOKENS_CHANGED` event. Instead the `auth` service is now an `EventEmitter` and the `session` service subscribes directly to `oauthTokensChanged` events from it. Whereas we replaced most other events with observers which react to data changing in the store, this particular use case doesn't lend itself to that and it makes more sense for the `auth` service to emit events to notify interested consumers.
-
Robert Knight authored
Replace the `BEFORE_ANNOTATION_CREATED` event
-
Robert Knight authored
- Move a comment down to the `useEffect` call it referred to - Reword the note about what happens when there are multiple unsaved annotations and the newest one is removed or saved
-
Lyza Danger Gardner authored
-
Lyza Gardner authored
Remove redundant “Select” and “tabs” verbiage
-
- 20 May, 2020 6 commits
-
-
Lyza Danger Gardner authored
-
Robert Knight authored
It is possible for multiple unsaved annotations to exist if a user creates a new annotation, enters some text but does not save, and then creates another new annotation. In this case, make the thread list always scroll to the newest. A side effect of the implementation is that if this second annotation is then deleted or saved, the thread list will scroll back to the previous unsaved annotation. This behavior seems useful, so I've kept it.
-
Robert Knight authored
The `BEFORE_ANNOTATION_CREATED` event was used for two purposes: 1. Invoke `annotationsService.create(...)` to create the annotation in the sidebar. 2. Scroll the newly created annotation into view Resolve (1) by calling `annotationsService.create` directly from the `frameSync` service and resolve (2) by watching for changes to `unsavedAnnotations()` in the store and scrolling to the new annotation when it appears. There is one functional change which is that replies will be scrolled into view, as this seems like a useful behavior if the user clicks the "Reply" button for a thread and the input field appears below the bottom of the screen.
-
Lyza Gardner authored
Improve loading state for LMS, all users
-
Robert Knight authored
Make fetch exceptions consistent and filter them from Sentry
-
Robert Knight authored
Improve handling of annotation fetch error in single annotation view
-
- 19 May, 2020 16 commits
-
-
Robert Knight authored
Previously if the user visited a `/a/<ID>` URL and the request to fetch the annotation failed with a 404 then the user would see a blank page. If the fetch failed because the annotation was private, logging in did not cause the annotation to be fetched. This commit resolves the two issues: - When the logged-in user changes, re-fetch the annotation - If the annotation fetch fails, an "Annotation unavailable" message is shown. This currently repurposes the error that is shown when a direct-linked annotation fetch fails, but without the "Clear selection" button. This commit also fixes an issue where a direct link to a group that could not be fetched would show a "Clear selection" button even though there was no active selection to clear. That button is only needed when following a direct link to an annotation.
-
Lyza Danger Gardner authored
For the places in the application that we care about whether “things are currently loading”, whether annotations have ever been fetched is relevant. Consider the application to be loading if there are any in-flight API requests OR annotations have never been successfully loaded.
-
Lyza Danger Gardner authored
Fixes #2018
-
Lyza Danger Gardner authored
Different browsers format Fetch errors differently; give them some sort of consistency by re-throwing something with a common string. This will allows us to filter out fetch errors from sentry logging, as well.
-
Lyza Gardner authored
Consolidate CSS font rules in `annotator` SCSS
-
dependabot-preview[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 17.6.0 to 17.9.1. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v17.6.0...v17.9.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Bump chance from 1.1.4 to 1.1.5
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.673.0 to 2.679.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.673.0...v2.679.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Bump puppeteer from 3.0.4 to 3.1.0
-
dependabot-preview[bot] authored
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.19.0 to 7.20.0. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.19.0...v7.20.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 3.0.4 to 3.1.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Commits](https://github.com/puppeteer/puppeteer/compare/v3.0.4...v3.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Bump karma from 5.0.5 to 5.0.8
-
Robert Knight authored
Bump fetch-mock from 9.5.1 to 9.9.0
-
Robert Knight authored
Bump codecov from 3.6.5 to 3.7.0
-
Robert Knight authored
Bump autoprefixer from 9.7.6 to 9.8.0
-
Robert Knight authored
Fix race condition and error handling when fetching groups in LMS app
-