Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 08 Sep, 2020 12 commits
  3. 07 Sep, 2020 4 commits
  5. 03 Sep, 2020 3 commits
    • Lyza Danger Gardner's avatar
      Adjust keyboard interaction with TagEditor · 0b9a114f
      Lyza Danger Gardner authored
      0b9a114f
    • Lyza Danger Gardner's avatar
      Add list-item formatter for suggested tags list · b32cbefb
      Lyza Danger Gardner authored 
      Help user see what part of an entered tag is a match for a suggested tag
      b32cbefb
    • Lyza Danger Gardner's avatar
      Suggested tag matching should not use lookback · b8ad9722
      Lyza Danger Gardner authored 
      Change the matching logic for determining whether a given suggested tag
(`tag`) matches the currently-typed tag field text (`query`).

Formerly, `tag` would match `query` if `tag` were a substring of `query`
in any position. However, this creates a lot of noise in the matches and
is not commonly what folks are after.

Now, `tag` will match `query` if:

* `tag` starts with `query` OR
* `query` occurs within `tag` after a word boundary or a non-word
   character

Thus, a `query` of "app":

* Would match the `tag` "apple"
* Would match the `tag` "crab apple" ("app" occurs after a word boundary)
* Would match the `tag` "crab.apple" ("app" occurs after non-word char)
* Would NOT match the `tag` "crabapple"
      b8ad9722
  7. 02 Sep, 2020 6 commits
  9. 01 Sep, 2020 11 commits
  11. 28 Aug, 2020 1 commit
    • Robert Knight's avatar
      Remove sidebar toggle button swipe gesture handling · 3c849a81
      Robert Knight authored 
      Remove logic for handling swipe gestures on the sidebar's toggle button.
Trying to perform a swipe on a target as small as the toggle button is
difficult and it doesn't offer advantages over just tapping the button
to open and close. Behavior that _might_ be useful is being able to
two-finger swipe on the whole sidebar to open or close it, but this conflicts
with the browser's own swipe gesture handling. Just remove it entirely
for now.

 - Remove swipe gesture handling

 - Remove unnecessary use of jQuery

 - Ensure that the `_setupGestures` code path is exercised by tests
      3c849a81
  13. 27 Aug, 2020 3 commits
    • Robert Knight's avatar
      Convert tests for src/annotator/sidebar.js to JS · 43b7fef8
      Robert Knight authored 
      This is a direct conversion with decaffeinate [1] followed by a manual
line-by-line review to remove unnecessary `return` statements, fix lint
errors and ensure consistency with our conventions.

[1] https://github.com/decaffeinate/decaffeinate
      43b7fef8
    • Robert Knight's avatar
      Add a couple of comments in response to PR feedback · 98d001bd
      Robert Knight authored
      98d001bd
    • Robert Knight's avatar
      Convert src/annotator/sidebar.coffee to JS · 49c5b09b
      Robert Knight authored 
      Convert this module, but not its tests, to JS. This is a pretty
straightforward conversion with a few minor improvements:

 - The initialization of `options` was rewritten in a way that is
   consistent with `PdfSidebar` and avoids a non-idiomatic way of
   passing initialization parameters from derived to base class

 - Some comments that were hard to parse were rewritten or removed if
   they stated something obvious

 - Private methods and fields related to gesture state were prefixed
   with an underscore. Some of the sidebar tests did and still do access
   these, which is not ideal.
      49c5b09b