1. 26 Jan, 2024 2 commits
  2. 25 Jan, 2024 3 commits
  3. 24 Jan, 2024 4 commits
  4. 23 Jan, 2024 2 commits
  5. 22 Jan, 2024 13 commits
  6. 19 Jan, 2024 5 commits
    • Robert Knight's avatar
      Remove `user` property from `focusFilters` state when no user selected · ccb0f77b
      Robert Knight authored
      Several pieces of code tested only for the presence of keys in `focusFilters` to
      determine whether a focus filter was configured, rather than whether the
      property was set to a "valid" value for that particular filter. The
      `changeFocusModeUser` store action would always set this property, instead of
      removing it when the passed user info was empty (logically meaning "no user is
      focused").
      
      Fixes https://github.com/hypothesis/client/issues/6109
      ccb0f77b
    • Robert Knight's avatar
      Make selection override other filters · befe424f
      Robert Knight authored
      When the user clicks highlight(s) in the document and makes a "selection" in the
      sidebar, we want the selected threads to always be visible. Previously this was
      handled by clearing other types of filter when the selection was made, in
      addition to setting the selection. This however meant that after the selection
      was cleared, the state was different than prior to making the selection, with
      any non-selection filters being disabled.
      
      This commit changes the behavior so that the selection, if present, temporarily
      overrides other filters rather than being combined with them. This allows the
      selection to later be removed to revert back to the previous state.
      befe424f
    • Robert Knight's avatar
      Don't clear filters when clearing selection · bbd6408d
      Robert Knight authored
      When focus filters are in use (eg. user / page filters) it is annoying if
      clicking a highlight in the document and then clearing the selection has the
      effect of disabling the focus filters. Instead the plan is to have the selection
      temporarily replace filters when active.
      bbd6408d
    • Alejandro Celaya's avatar
    • Alejandro Celaya's avatar
      33cb5da1
  7. 18 Jan, 2024 4 commits
  8. 17 Jan, 2024 5 commits
  9. 16 Jan, 2024 2 commits